Skip to content

Conversation

@atheendre130505
Copy link
Contributor

@atheendre130505 atheendre130505 commented Oct 26, 2025

This PR addresses incomplete Javadoc comments in the storage module. It
adds proper descriptions to all relevant Javadoc tags according to
Apache Kafka documentation standards:

Adds missing @return description in ProducerManager.publishMessage()

Adds missing @return description in
RemoteLogMetadataCache.listAllRemoteLogSegments()

Adds missing @throws description in
LogDirFailureChannel.takeNextOfflineLogDir()

No functional code changes are introduced. All updates are strictly to
improve code documentation clarity and compliance.

Reviewers: Chia-Ping Tsai [email protected]

- Add missing @return description in ProducerManager.publishMessage()
- Add missing @return description in RemoteLogMetadataCache.listAllRemoteLogSegments()
- Add missing @throws description in LogDirFailureChannel.takeNextOfflineLogDir()

All Javadoc tags now have proper descriptions following Apache Kafka documentation standards.
@github-actions github-actions bot added triage PRs from the community storage Pull requests that target the storage module tiered-storage Related to the Tiered Storage feature small Small PRs labels Oct 26, 2025
@FrankYang0529
Copy link
Member

@atheendre130505 Thanks for the contribution. Could you follow the guide to modify PR title? Thanks.

https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@atheendre130505 atheendre130505 changed the title Fix incomplete Javadoc comments in storage module MINOR: Fix incomplete Javadoc comments in storage module Nov 4, 2025
@atheendre130505
Copy link
Contributor Author

@chia7712 @FrankYang0529 All checks have passed. Ready for merge. Thanks!

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit de7e632 into apache:trunk Nov 10, 2025
25 checks passed
@chia7712
Copy link
Member

@atheendre130505 thanks for this patch!

@github-actions github-actions bot removed needs-attention triage PRs from the community labels Nov 11, 2025
eduwercamacaro pushed a commit to littlehorse-enterprises/kafka that referenced this pull request Nov 12, 2025
This PR addresses incomplete Javadoc comments in the storage module. It
adds proper descriptions to all relevant Javadoc tags according to
Apache Kafka documentation standards:

Adds missing @return description in ProducerManager.publishMessage()

Adds missing @return description in
RemoteLogMetadataCache.listAllRemoteLogSegments()

Adds missing @throws description in
LogDirFailureChannel.takeNextOfflineLogDir()

No functional code changes are introduced. All updates are strictly to
improve code documentation clarity and compliance.

Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved small Small PRs storage Pull requests that target the storage module tiered-storage Related to the Tiered Storage feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants